347
edits
Hacking:Making pull requests: Difference between revisions
→General recommendations
Line 28:
There are several things you should know for successful creating a pull request.
[[File:Workflow mercurial.png|center]]
* As open source community we try to be open as possible. This mean if your changes fix something, extend or add new feature and not goes against our goals we will merge such a patch. Even if this patch is not perfect. This rule guarantee that you will not stuck with requests to fix your changes. We will help you by continue working with your code after merging.
* Normally you are not allowed create named branch with name except '''feature'''. Instead you will use so called anonymous heads, see [http://stevelosh.com/blog/2009/08/a-guide-to-branching-in-mercurial/ a Guide to Branching in Mercurial]. In short a name of a named branch show us developing process only, we don't care contains it issue ticket number or not. Named branches only for long term task specific changes.
* Please start your changes from '''develop''' or '''release''' head commit. For this run command <code>hg update name_of_branch</code>. Which branch to select depend on in which state the code base is now. See section [[Hacking:Making_pull_requests#Branch_model|Branch model]]. If you are not sure, please, ask for help.
| |||