Hacking:Making pull requests: Difference between revisions
Content added Content deleted
No edit summary |
|||
| Line 14: | Line 14: | ||
These are the main branches you should know about. There are several long term task specific branches in repository too. But we will not discuss them in this document. |
These are the main branches you should know about. There are several long term task specific branches in repository too. But we will not discuss them in this document. |
||
| ⚫ | |||
| ⚫ | |||
| ⚫ | |||
| ⚫ | * As open source community we try to be open as possible. This mean if your changes fix something, extend or add new feature and not goes against our goals we will merge such a patch. Even if this patch is not perfect. This rule guarantee that you will not stuck with requests to fix your changes. We will help you by continue working with your code after merging. |
||
| ⚫ | * It is easiest for others to understand your intent if you follow naming conventions. Please use a convention of creating a branch to save your work in the github repository. For example, a fix for an issue from the list would go in a branch named issue-xxx. See [https://guides.github.com/introduction/git-handbook/ the github handbook] for more information about how to use the github tools. |
||
| ⚫ | * Please start your changes from [https://github.com/FashionFreedom/Seamly2D/tree/develop the Seamly2D repository '''develop''' branch]. You may use the fork command to create your own copy of the repository. If you are not sure, please, ask for help in the [https://forum.seamly.net/c/developer forum]. |
||
== Working with feature development == |
== Working with feature development == |
||
| Line 25: | Line 32: | ||
* When you will decide that all were done create a pull request. In settings set to push your '''develop/release''' branch to the upstream repository. |
* When you will decide that all were done create a pull request. In settings set to push your '''develop/release''' branch to the upstream repository. |
||
* If we ask you to fix some issues related to your changes continue commit them to the '''develop/release''' branch and push them to github. It will automatically update your pull request. |
* If we ask you to fix some issues related to your changes continue commit them to the '''develop/release''' branch and push them to github. It will automatically update your pull request. |
||
| ⚫ | |||
| ⚫ | |||
| ⚫ | |||
| ⚫ | * As open source community we try to be open as possible. This mean if your changes fix something, extend or add new feature and not goes against our goals we will merge such a patch. Even if this patch is not perfect. This rule guarantee that you will not stuck with requests to fix your changes. We will help you by continue working with your code after merging. |
||
| ⚫ | * It is easiest for others to understand your intent if you follow naming conventions. Please use a convention of creating a branch to save your work in the github repository. For example, a fix for an issue from the list would go in a branch named issue-xxx. See [https://guides.github.com/introduction/git-handbook/ the github handbook] for more information about how to use the github tools. |
||
| ⚫ | * Please start your changes from [https://github.com/FashionFreedom/Seamly2D/tree/develop the Seamly2D repository '''develop''' branch]. You may use the fork command to create your own copy of the repository. If you are not sure, please, ask for help in the [https://forum.seamly.net/c/developer forum]. |
||