Hacking:Making pull requests: Difference between revisions

Content added Content deleted
No edit summary
Line 30: Line 30:
NOTE: INSERT UPDATED, GIT BASED, WORKFLOW EXAMPLE HERE
NOTE: INSERT UPDATED, GIT BASED, WORKFLOW EXAMPLE HERE
* As open source community we try to be open as possible. This mean if your changes fix something, extend or add new feature and not goes against our goals we will merge such a patch. Even if this patch is not perfect. This rule guarantee that you will not stuck with requests to fix your changes. We will help you by continue working with your code after merging.
* As open source community we try to be open as possible. This mean if your changes fix something, extend or add new feature and not goes against our goals we will merge such a patch. Even if this patch is not perfect. This rule guarantee that you will not stuck with requests to fix your changes. We will help you by continue working with your code after merging.
* It is easiest for others to understand your intent if you follow naming conventions. Please use a convention of creating a branch to save your work in the github repository. For example, a fix for an issue from the list would go in a branch named issue-xxx. See [https://guides.github.com/introduction/git-handbook/ the github handbook] for more information about how to use the github tools.
* Normally you are not allowed create your named branch with name except '''develop'''. Instead you will use so called anonymous heads, see [http://stevelosh.com/blog/2009/08/a-guide-to-branching-in-mercurial/ a Guide to Branching in Mercurial]. In short a name of a named branch show us developing process only, we don't care contains it issue ticket number or not. Named branches only for long term task specific changes.
* Please start your changes from '''develop''' or '''release''' head commit. For this run command <code>hg update name_of_branch</code>. Which branch to select depend on in which state the code base is now. See section [[Hacking:Making_pull_requests#Branch_model|Branch model]]. If you are not sure, please, ask for help.
* Please start your changes from '''develop''' or '''release''' head commit. For this run command <code>hg update name_of_branch</code>. Which branch to select depend on in which state the code base is now. See section [[Hacking:Making_pull_requests#Branch_model|Branch model]]. If you are not sure, please, ask for help.
* Before starting committing your changes open your '''develop''' branch head. For this run command <code>hg branch -f develop</code>.
* Before starting committing your changes open your '''develop''' branch head. For this run command <code>hg branch -f develop</code>.