Hacking:Making pull requests: Difference between revisions
Content added Content deleted
| Line 32: | Line 32: | ||
* It is easiest for others to understand your intent if you follow naming conventions. Please use a convention of creating a branch to save your work in the github repository. For example, a fix for an issue from the list would go in a branch named issue-xxx. See [https://guides.github.com/introduction/git-handbook/ the github handbook] for more information about how to use the github tools. |
* It is easiest for others to understand your intent if you follow naming conventions. Please use a convention of creating a branch to save your work in the github repository. For example, a fix for an issue from the list would go in a branch named issue-xxx. See [https://guides.github.com/introduction/git-handbook/ the github handbook] for more information about how to use the github tools. |
||
* Please start your changes from '''develop''' or '''release''' head commit. For this run command <code>hg update name_of_branch</code>. Which branch to select depend on in which state the code base is now. See section [[Hacking:Making_pull_requests#Branch_model|Branch model]]. If you are not sure, please, ask for help. |
* Please start your changes from '''develop''' or '''release''' head commit. For this run command <code>hg update name_of_branch</code>. Which branch to select depend on in which state the code base is now. See section [[Hacking:Making_pull_requests#Branch_model|Branch model]]. If you are not sure, please, ask for help. |
||
* Before starting committing your changes open your '''develop''' branch |
* Before starting committing your changes open your [https://github.com/FashionFreedom/Seamly2D the Seamly2D repository '''develop''' branch]. For this run command <code>hg branch -f develop</code>. |
||
* Now you are ready to begin work. Make some changes and commit them with command <code>hg commit -m "Commit comment."</code>. |
* Now you are ready to begin work. Make some changes and commit them with command <code>hg commit -m "Commit comment."</code>. |
||
* When you are ready open new pull request. Please, read carefully official tutorial from Atlassian [https://www.atlassian.com/git/tutorials/making-a-pull-request Making a Pull Request]. This tutorial will help you understand how to work with bitbucket web site. '''But don't forget to return to this page and read it all. We have warned you.''' |
* When you are ready open new pull request. Please, read carefully official tutorial from Atlassian [https://www.atlassian.com/git/tutorials/making-a-pull-request Making a Pull Request]. This tutorial will help you understand how to work with bitbucket web site. '''But don't forget to return to this page and read it all. We have warned you.''' |
||